Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18366
merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78776 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78776/testReport)**
for PR 18366 at commit
[`7771404`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78776/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78776 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78776/testReport)**
for PR 18366 at commit
[`7771404`](https://github.com/apache/spark/commit/77
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78764/testReport)**
for PR 18366 at commit
[`7771404`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78764/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78763 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78763/testReport)**
for PR 18366 at commit
[`cabccd3`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78763/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78759/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78759/testReport)**
for PR 18366 at commit
[`0ba66fd`](https://github.com/apache/spark/commit/0
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78764/testReport)**
for PR 18366 at commit
[`7771404`](https://github.com/apache/spark/commit/77
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
I see what you mean. Updated now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78763 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78763/testReport)**
for PR 18366 at commit
[`cabccd3`](https://github.com/apache/spark/commit/ca
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18366
ah, I see
https://github.com/apache/spark/pull/18366/commits/0ba66fd00b76874adbc80c483cfad735bdaf11f5#diff-d97f9adc2dcac0703568c799ff106987R98
I think we only need people to see deta
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
You mean add `See 'details'` to the doc of `x`? If so, yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18366
did you catch this
https://github.com/apache/spark/pull/18366#issuecomment-311558620
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78759/testReport)**
for PR 18366 at commit
[`0ba66fd`](https://github.com/apache/spark/commit/0b
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
OK. Incorporated your suggested changes now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18366
thanks, re https://github.com/apache/spark/pull/18366#issuecomment-310974184
I think I'm going to suggest adding `See Details` at the end for the param
doc for `x` like in here
https://stat.
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
@felixcheung @HyukjinKwon Anything else needed for this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78656/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78656 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78656/testReport)**
for PR 18366 at commit
[`93ac00a`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78656 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78656/testReport)**
for PR 18366 at commit
[`93ac00a`](https://github.com/apache/spark/commit/93
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78615/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78615 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78615/testReport)**
for PR 18366 at commit
[`93ac00a`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78615 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78615/testReport)**
for PR 18366 at commit
[`93ac00a`](https://github.com/apache/spark/commit/93
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78610 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78610/testReport)**
for PR 18366 at commit
[`93ac00a`](https://github.com/apache/spark/commit/9
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78610/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
Thank you @HyukjinKwon for checking it.
@felixcheung Please let me know if there is anything else needed on this
one.
---
If your project is set up for it, you can reply to this email an
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18366
(^ I meant literally contents and examples)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18366
The contents/examples I checked look okay to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78610 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78610/testReport)**
for PR 18366 at commit
[`93ac00a`](https://github.com/apache/spark/commit/93
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
@felixcheung Since there are only two methods with argument signature `(y,
x)`, I think it's best to document them together with the other string
methods. Also, not aiming to rename the parame
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18366
hmm, comment not showing up:
https://github.com/apache/spark/pull/18366/files#r123891161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
@felixcheung appveyor has been queued for a long time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78533/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78533 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78533/testReport)**
for PR 18366 at commit
[`1a6908d`](https://github.com/apache/spark/commit/1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78533 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78533/testReport)**
for PR 18366 at commit
[`1a6908d`](https://github.com/apache/spark/commit/1a
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
@felixcheung Thanks much for the review. Made a new commit that addresses
all your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78465/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78465 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78465/testReport)**
for PR 18366 at commit
[`dd707d8`](https://github.com/apache/spark/commit/d
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78465 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78465/testReport)**
for PR 18366 at commit
[`dd707d8`](https://github.com/apache/spark/commit/dd
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78434 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78434/testReport)**
for PR 18366 at commit
[`4c0e112`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78434/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78434 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78434/testReport)**
for PR 18366 at commit
[`4c0e112`](https://github.com/apache/spark/commit/4c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78413 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78413/testReport)**
for PR 18366 at commit
[`a1de1c0`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78413/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78413 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78413/testReport)**
for PR 18366 at commit
[`a1de1c0`](https://github.com/apache/spark/commit/a1
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/18366
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78374/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78374 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78374/testReport)**
for PR 18366 at commit
[`a1de1c0`](https://github.com/apache/spark/commit/a1
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78310 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78310/testReport)**
for PR 18366 at commit
[`a1de1c0`](https://github.com/apache/spark/commit/a
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78310/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78310 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78310/testReport)**
for PR 18366 at commit
[`a1de1c0`](https://github.com/apache/spark/commit/a1
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/18366
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/18366
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/18366
i will retrigger this once jenkins restarts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78302/
Test FAILed.
---
Github user shaneknapp commented on the issue:
https://github.com/apache/spark/pull/18366
i will retrigger this once jenkins restart
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78306/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18366
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78306 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78306/testReport)**
for PR 18366 at commit
[`a1de1c0`](https://github.com/apache/spark/commit/a1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18366
**[Test build #78302 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78302/testReport)**
for PR 18366 at commit
[`d2c5b8d`](https://github.com/apache/spark/commit/d2
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
@felixcheung @HyukjinKwon
This one is pretty straightforward. See the screenshot below.
