Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
This is followed by #18704
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80629/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80629 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80629/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80629 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80629/testReport)**
for PR 18468 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80619/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80619/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80619 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80619/testReport)**
for PR 18468 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18468
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80314/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80314 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80314/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80314 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80314/testReport)**
for PR 18468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80311/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80311 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80311/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80311 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80311/testReport)**
for PR 18468 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
ping @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80128/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80128 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80128/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #80128 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80128/testReport)**
for PR 18468 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
@cloud-fan how will we go forward? @rxin seems to have no comment for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
ping @cloud-fan, @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
ping @cloud-fan, @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
@rxin As you suggested, I implemented batch approach in [this
PR](https://github.com/apache/spark/pull/18704). Which one would it be good to
merge into the master?
cc: @cloud-fan
---
If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79828/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79828 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79828/testReport)**
for PR 18468 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
I think that this failure is not related to changes of this PR.
@cloud-fan what option will we choose? I think that the followings are
possible options:
1. merge this PR only to take this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79828 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79828/testReport)**
for PR 18468 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79824 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79824/testReport)**
for PR 18468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79824/
Test FAILed.
---
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
@rxin IIUC, you like the batch approach due to the small block size. Why
you do not like to take the adapter approach?
---
If your project is set up for it, you can reply to this email and have your
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
@cloud-fan what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18468
Uncompress a small block at a time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
@rxin Thank you for your comment. Once I created such an implementation in
another PR.
When I talked with @cloud-fan, the issue in batch approach is large
footprint since the batch approach once
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18468
Hey sorry for commenting late, but I don't think this change really makes
sense. If anything, I'd decompress data in batch into uncompressed column
batch, rather than building an adapter.
---
If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79817/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79817 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79817/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79824 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79824/testReport)**
for PR 18468 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/18468
I saw @rxin's comment at #18680 on the performance implications for new
column vector implementation. As this introduces another implementation, shall
we consider the issue for this too?
---
If
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79817 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79817/testReport)**
for PR 18468 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
ping @cloud-fan , @ueshin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79811/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79811 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79811/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79811 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79811/testReport)**
for PR 18468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79803/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79803 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79803/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79803/testReport)**
for PR 18468 at commit
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/18468
cc: @cloud-fan and @ueshin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79783/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79783 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79783/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79783 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79783/testReport)**
for PR 18468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79765/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79765 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79765/testReport)**
for PR 18468 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79765 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79765/testReport)**
for PR 18468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79759/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79759 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79759/testReport)**
for PR 18468 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/18468
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79759 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79759/testReport)**
for PR 18468 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18468
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79748/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18468
**[Test build #79748 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79748/testReport)**
for PR 18468 at commit
74 matches
Mail list logo