[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-10 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18565 thanks, merging to master/2.2! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79452/ Test PASSed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79452 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79452/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79452 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79452/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-10 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18565 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79438/ Test FAILed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79438/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79438/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79435/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79435/ Test FAILed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79435/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/18565 @jinxing64 I submitted https://github.com/jinxing64/spark/pull/1 to your repo to fix a potential file leak. Otherwise, this looks good to me. --- If your project is set up for it, you can reply to

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79422/ Test PASSed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79422/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79422/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79420/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79420/ Test FAILed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79420/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79410/ Test PASSed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79410/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79409/ Test PASSed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79409 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79409/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79408/ Test PASSed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79408 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79408/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18565 LGTM except 2 minor comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18565 In current change: 1. I'm using `java.util.function.Supplier` instead of `TmpFileCreater` 2. Pass `shuffleBlockFetcherIteratorIsZombie` from `ShuffleBlockFetcherIterator` to

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79410/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79409 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79409/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79408/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79390/ Test PASSed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79390/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79389/ Test PASSed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79389/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79390/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79389/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79378/ Test PASSed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79378 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79378/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18565 There are some corner cases because of creating and deleting in both `ShuffleBlockFetcherIterator` and `OneForOneBlockFetcher`. It seems no need to pass the `shuffleFiles` from

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79378/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79335/ Test PASSed. ---

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18565 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79335/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18565 **[Test build #79335 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79335/testReport)** for PR 18565 at commit

[GitHub] spark issue #18565: [SPARK-21342] Fix DownloadCallback to work well with Ret...

2017-07-07 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18565 cc @zsxwing @cloud-fan @jiangxb1987 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature