[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18634 thanks, merging to master/2.2! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18634 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18634 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79753/ Test PASSed. ---

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18634 **[Test build #79753 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79753/testReport)** for PR 18634 at commit

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-19 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18634 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18634 **[Test build #79753 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79753/testReport)** for PR 18634 at commit

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-17 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18634 @cloud-fan @jiangxb1987 Thanks for help! I will refine and post the result of manual test late today :) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18634 @jinxing64 I think this patch is straightforward, can you do a manual test, which OOM before and works after this PR? We can put the test in PR description so that other people can try it out.

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18634 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18634 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79671/ Test PASSed. ---

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18634 **[Test build #79671 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79671/testReport)** for PR 18634 at commit

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-17 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18634 @jiangxb1987 Thanks a lot for quick reply ! > One concern is the test case don't reflect the improvement of this change. Yes, there is no unit test for `WindowFunctionFrame` now.

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18634 **[Test build #79671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79671/testReport)** for PR 18634 at commit

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-17 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18634 cc @cloud-fan @jiangxb1987 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18634 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18634 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79608/ Test PASSed. ---

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18634 **[Test build #79608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79608/testReport)** for PR 18634 at commit

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18634 **[Test build #79608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79608/testReport)** for PR 18634 at commit

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18634 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/18634 retest please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18634 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79605/ Test FAILed. ---

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18634 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18634 **[Test build #79605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79605/testReport)** for PR 18634 at commit

[GitHub] spark issue #18634: [SPARK-21414] Refine SlidingWindowFunctionFrame to avoid...

2017-07-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18634 **[Test build #79605 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79605/testReport)** for PR 18634 at commit