Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
The status here is that this change does work fine with Scala 2.11, and
does implement changes that will be needed for 2.12. Right now I've found that,
suddenly, it doesn't compile for Scala 2.12:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81255/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #81255 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81255/testReport)**
for PR 18645 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #81255 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81255/testReport)**
for PR 18645 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81184/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #81184 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81184/testReport)**
for PR 18645 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #81184 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81184/testReport)**
for PR 18645 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #3905 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3905/testReport)**
for PR 18645 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #3905 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3905/testReport)**
for PR 18645 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #81143 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81143/testReport)**
for PR 18645 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81143/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #81143 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81143/testReport)**
for PR 18645 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81037/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #81037 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81037/testReport)**
for PR 18645 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #81037 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81037/testReport)**
for PR 18645 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80074/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #80074 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80074/testReport)**
for PR 18645 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #80074 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80074/testReport)**
for PR 18645 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
The json4s change above made this change notably simpler. The current
problem is the same, next error:
```
sbt.ForkMain$ForkError: java.lang.ClassCastException: java.lang.Integer
cannot
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80057/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #80057 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80057/testReport)**
for PR 18645 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #80057 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80057/testReport)**
for PR 18645 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
Oh nice, it will help if that's not a required update along with everything
else here as it requires a Jackson update. The Jackson update may be important
eventually but nice if it can be separate.
Github user xuwei-k commented on the issue:
https://github.com/apache/spark/pull/18645
json4s 3.2.11 for Scala 2.12 released
-
https://oss.sonatype.org/content/repositories/releases/org/json4s/json4s-jackson_2.12/3.2.11
-
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79968/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79968 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79968/testReport)**
for PR 18645 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
I believe the last errors were essentially the same issue discussed in
json4s here:
https://github.com/json4s/json4s/issues/227
I suspect that it's down to a change in the effective
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79968 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79968/testReport)**
for PR 18645 at commit
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/18645
Looking at the source compatibility changes made here, I was a little
confused about why we didn't need to make many more changes. In principle, it
seemed like the ambiguous overload issue
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79892/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79892 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79892/testReport)**
for PR 18645 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
That's not an upgrade. spark_2.11 2.2.0 to spark_2.11 2.3.0 is an upgrade,
and that can't break, and doesn't with this change.
Or: Scala itself has never been source- or binary-compatible
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18645
When users upgrade from 2.11 to 2.12, their app would be broken, wouldn't
it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
Are we talking about the same thing? this does not break source
compatibility for Scala 2.11. Scala 2.12, yes. But that has never been binary,
or necessarily source, compatible. What's different?
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18645
@srowen I don't agree that we should just break source compatibility here.
We have already spent a lot of time doing this in the past and figuring out how
to preserve it.
---
If your project is set
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79892 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79892/testReport)**
for PR 18645 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
The JSON error arises because now, JSON messages contain an explicit entry
for null properties, like `"message" : null`. This looks like a small behavior
change introduced in Jackson 2.7. See
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
@rxin it's definitely breaking between Scala 2.11 and Scala 2.12, but not
for the Scala 2.11 build. Ideally, we find it's possible to enable a 2.12
build, such that the changes are binary and source
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18645
It is still source breaking change, and this is why I was saying it would
be a lot of work to upgrade to Scala 2.12 without breaking existing source
code. For 2.12 we should get rid of the functions
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
@rxin (See above for what I think you are referring to.)
I do now see tests failing that diff JSON, but that's probably because the
Jackson version had to change. (This is a WIP.) And I
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18645
@srowen You just showed that the Scala 2.12 changes are source breaking,
isn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79851/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79851 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79851/testReport)**
for PR 18645 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79851 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79851/testReport)**
for PR 18645 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79645/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79645 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79645/testReport)**
for PR 18645 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79645 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79645/testReport)**
for PR 18645 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79643/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79643 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79643/testReport)**
for PR 18645 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18645
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18645
**[Test build #79643 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79643/testReport)**
for PR 18645 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18645
CC @rxin since you asked; CC @JoshRosen
Just a WIP now of course, but wanted to table a take on most of the
remaining gap we can bridge right now towards 2.12.
---
If your project is set up
63 matches
Mail list logo
