Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
Nice. Thanks for trying it out!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/18702
I tested locally, and it's fine if I install mkdocs and run
sql/create-docs.sh
Thanks for fixing it!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
Will test this in a bare machine and open a PR in any event. The changes
should be small.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
Oh, yes it looks so. Will update this script to install `pip install
mkdocs` if `mkdocs` is missing in the path, if you are not looking into this.
Does this fail to build the doc even after
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/18702
@HyukjinKwon It looks like the Jenkins doc build was broken by this PR (and
I can't build it locally either). Is it just that the script needs to be
updated to run sql/create-docs.sh ?
---
If
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
Thank you @srowen and @rxin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18702
LGTM too.
Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
I am fine with leaving it to me too :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
I guess it probably will take about a week more for my Apache account
creation (according to the doc).
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18702
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79953/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18702
**[Test build #79953 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79953/testReport)**
for PR 18702 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
@srowen, I tried to resemble, in particular, R:
```
.
âââ docs
âââ sql
âââ create-docs.sh # Generates HTMLs.
âââ
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18702
**[Test build #79953 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79953/testReport)**
for PR 18702 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18702
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18702
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79931/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18702
**[Test build #79931 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79931/testReport)**
for PR 18702 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
Thank you @srowen. I will double check and clean up minor nits and will
ping you within tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18702
Oh I see, it's for consistency. Well OK stay consistent with R/Python then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
(sorry, I just edited the structure above to be more correct)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
In any case, it is easy. I was just thinking of matching it up with, like,
R and Python which are, up to my knowledge, something like the below:
**R**:
```
.
âââ docs
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18702
Yeah the latter is what I had in mind but I don't know, is it hard? it does
seem more natural to generate the output directly into its destination, I
think, unless I'm overlooking something else the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
@srowen, so, the current structure is like ...
```
.
âââ docs
âââ sql
âââ create-docs.sh # Genenerates HTMLs.
âââ
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18702
**[Test build #79931 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79931/testReport)**
for PR 18702 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
I addressed the log4j comment for now first (I got rid of log4j file by
avoiding directly accessing to JVM)
---
If your project is set up for it, you can reply to this email and have your
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
(I got rid of log4j file by avoiding directly accessing to JVM)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/18702
@rxin, do you have any thought on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
27 matches
Mail list logo
