Github user highfei2011 commented on the issue:
https://github.com/apache/spark/pull/18807
Hi, @srowen @markhamstra ,This problem has been
solvedï¼[https://github.com/apache/spark/pull/18808](url)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/18807
Yes, it doesn't really hurt anything except to be confusing cruft that has
a tendency to accumulate in POMs. If we're going to put those lines back, I
suggest that they be accompanied by a comme
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18807
Sure, it really doesn't hurt, because we already define and maintain
`${java.version}` anyway. It's two lines of standard config that were already
there. This is truly not an issue.
---
If your pro
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/18807
Maven is the build of reference, true; but maven itself doesn't need the
JDK version to be specified both in the scala plugin configuration and in the
compiler plugin configuration. While I unde
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18807
The Maven build is the build of reference, and we rely on IDEs to parse the
details of the build from the pom.xml file. So it's right for the IDE to need
to find information like JDK level (among a h
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/18807
Hmmm... that's arguably broken behavior on the part of IntelliJ or
something to be worked around in IntelliJ configuration, not by hacking our
POM. Without the POM hack, though, it is definitely
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18807
@highfei2011 @markhamstra I think this is legit actually but for a
different reason: https://issues.apache.org/jira/browse/SPARK-21605
---
If your project is set up for it, you can reply to this ema
Github user highfei2011 commented on the issue:
https://github.com/apache/spark/pull/18807
Ok,Thanks, @markhamstra .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and w
Github user markhamstra commented on the issue:
https://github.com/apache/spark/pull/18807
These are maven-compiler-plugin configurations. We don't use
maven-compiler-plugin to compile Java code:
https://github.com/apache/spark/commit/74cda94c5e496e29f42f1044aab90cab7dbe9d38
---
If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18807
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
10 matches
Mail list logo
