Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18837
There are still some small issues (minor style nits, duplicating conf keys
instead of using `CONSTANT.key`), but well. I can't really comment on the
functionality itself so I'll trust your guys'
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/18837
Hello @vanzin should be consistent now. Thanks again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/18837
Hello @vanzin, thanks for the review. I added `.toSequence` to the new
configuration specs, certainly a nice solution to parsing on the fly. Please
let me know if there is anything else that needs
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18837
**[Test build #3904 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3904/testReport)**
for PR 18837 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18837
**[Test build #3904 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3904/testReport)**
for PR 18837 at commit
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/18837
Hello @srowen, thanks for taking a look at this. You're correct in that
this change does not require users to have a Mesos 1.3+ cluster, we do not
change or omit any required records in the proto
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/18837
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18837
**[Test build #3900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3900/testReport)**
for PR 18837 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18837
**[Test build #3900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3900/testReport)**
for PR 18837 at commit
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/18837
Hello @vanzin and @srowen, not trying to be a pest, but I would really
appreciate a review on this. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ArtRand commented on the issue:
https://github.com/apache/spark/pull/18837
Hello @srowen could you have a look at this (and green light the testing)
when you have a chance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/18837
Btw a lot of secrets are defined in the code base:
spark.secret.mesos,spark.mesos.driver.secret.name,
spark.authenticate.secret
(https://spark.apache.org/docs/latest/security.html) do you
12 matches
Mail list logo
