Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/18929
thanks @srowen @jerryshao @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18929
Since there's no explicit +1, I would suggest to leave the code as it is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18929
They're there mainly to declare the constant as a public API that must not
change. (I'm not sure whether mima captures changes in constant values, since
that's a binary breaking change, but that's
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18929
Maybe @vanzin can weigh in here, because the real question is whether these
constants in the launcher module are meant to be _the_ single definition of
them used throughout the code. core depends on
Github user heary-cao commented on the issue:
https://github.com/apache/spark/pull/18929
@srowen @jerryshao
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
