Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18935
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81420/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #81420 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81420/testReport)**
for PR 18935 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #81420 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81420/testReport)**
for PR 18935 at commit
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18935
Just realized the last build is 18 days ago. Triggered a new now. Will
merge after passing tests.
---
-
To unsubscribe, e-mail:
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18935
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18935
LGTM since enableVerboseMetrics is off by default. Merging to master.
Thanks!
---
-
To unsubscribe, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18935
The change itself looks good, but I'm afraid it's a bit too verbose to add
all of those metrics. cc @zsxwing .
---
-
To
Github user squito commented on the issue:
https://github.com/apache/spark/pull/18935
lgtm
any more thoughts @jiangxb1987 @zsxwing ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
@squito can you please review again? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
@squito , as the next following step, I would expose these metrics with
MetricsSystem, I'm thinking of exposing shuffle related Netty memory usage. For
RPC related memory usage, I'm not fully
Github user squito commented on the issue:
https://github.com/apache/spark/pull/18935
thanks for the added info @jerryshao.
(a) ok makes sense now about the use of this -- it is not exposed now, you
plan to expose it in future changes. That is fine, however I would like to
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
@squito , here is the list of full metrics I dumped from running
application. By default, if we don't enable verbose metric, only 2 metrics
("usedHeapMemory" and "usedDirectMemory") will be
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
Hi @squito , thanks a lot for your review. This PR doesn't expose Netty
metrics to MetricsSystem or collect to driver side (what did before), it just
provides a way for `TransportClientFactory`
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80835/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80835 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80835/testReport)**
for PR 18935 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80835 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80835/testReport)**
for PR 18935 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80829 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80829/testReport)**
for PR 18935 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80829/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80829 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80829/testReport)**
for PR 18935 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80822/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80822 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80822/testReport)**
for PR 18935 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80823/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80823 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80823/testReport)**
for PR 18935 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80823 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80823/testReport)**
for PR 18935 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80822 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80822/testReport)**
for PR 18935 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
Thanks @zsxwing . I was thinking to expose the details of memory allocation
in Netty for user to monitor and tune, user could filter out unrelated metrics.
Maybe you're right, it is too verbose
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18935
Could you bump the netty version to use its new APIs rather than reflection?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/18935
I'll review this tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
@jiangxb1987 @zsxwing would you please help to review this PR, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80662/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80662 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80662/testReport)**
for PR 18935 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80662 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80662/testReport)**
for PR 18935 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
Thanks @dongjoon-hyun for your review, will change it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80641/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80641 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80641/testReport)**
for PR 18935 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80641 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80641/testReport)**
for PR 18935 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/18935
Retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18935
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/80618/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80618/testReport)**
for PR 18935 at commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/18935
@jsoltren @squito I take the liberty to get another shot of exposing Netty
memory metrics. This PR doesn't address any display related things, only expose
memory usage from Netty client factory
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18935
**[Test build #80618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/80618/testReport)**
for PR 18935 at commit
52 matches
Mail list logo
