[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...

2017-08-24 Thread iamhumanbeing
Github user iamhumanbeing commented on the issue: https://github.com/apache/spark/pull/19037 ok. I will close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...

2017-08-24 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19037 Same, why do you think the test can or should be more specific? There is no motivation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...

2017-08-24 Thread iamhumanbeing
Github user iamhumanbeing commented on the issue: https://github.com/apache/spark/pull/19037 @srowen How about "assert(exchanges.map(_.outputPartitioning.numPartitions).sorted === List(2, 2, 2, 3))"? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...

2017-08-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19037 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...

2017-08-24 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19037 Are you sure that the test can rely on the ordering? it seems to explicitly not do so --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.