[GitHub] spark issue #19098: [SPARK-21583][HOTFIX] Removed intercept in test causing ...

2017-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19098 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81293/ Test PASSed. ---

[GitHub] spark issue #19098: [SPARK-21583][HOTFIX] Removed intercept in test causing ...

2017-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19098 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19098: [SPARK-21583][HOTFIX] Removed intercept in test causing ...

2017-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19098 **[Test build #81293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81293/testReport)** for PR 19098 at commit

[GitHub] spark issue #19098: [SPARK-21583][HOTFIX] Removed intercept in test causing ...

2017-08-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19098 The asserts are wrong if this can be called from user code. It should be `require`. The reason is, basically, exactly this. If you don't have assertions on this argument is accepted. --- If your

[GitHub] spark issue #19098: [SPARK-21583][HOTFIX] Removed intercept in test causing ...

2017-08-31 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/19098 @srowen , the assertion is from the Spark `ColumnarBatch`

[GitHub] spark issue #19098: [SPARK-21583][HOTFIX] Removed intercept in test causing ...

2017-08-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19098 Hm, I wonder how that results in an assertion? that's a normal error case and shouldn't cause an assert. Is it from a third-party library in this case, like Arrow? really we should fix that somehow

[GitHub] spark issue #19098: [SPARK-21583][HOTFIX] Removed intercept in test causing ...

2017-08-31 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19098 LGTM. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #19098: [SPARK-21583][HOTFIX] Removed intercept in test causing ...

2017-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19098 **[Test build #81293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81293/testReport)** for PR 19098 at commit