[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19174 Merged to master anyway. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19174 **[Test build #3919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3919/testReport)** for PR 19174 at commit

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19174 **[Test build #3919 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3919/testReport)** for PR 19174 at commit

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19174 Same, let's not bother with stuff this trivial @heary-cao please. If it really makes the code consistent on this one point, I'm not against this, other than that it encourages more PRs this

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-11 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19174 This seems not a big problem, all the temp files are created under `target/tmp`, this can be cleaned by `mvn clean` or `sbt clean`. ---

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-10 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19174 @kiszk thank you for review it. I checked the other test cases that use ` File.createTempFile` and `Files.createTempFile `. Except as described in this PR, others test cases that already

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-09 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19174 How about other test cases that use `File.createTempFile`? Did they clean the temp file correctly? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-09 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19174 Is it better to use ` DELETE_ON_CLOSE`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-09 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19174 This is too trivial to bother with. The JVM cleans this on shutdown anyway. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19174: [SPARK-21963][CORE][TEST]Create temp file should be dele...

2017-09-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19174 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional