[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-13 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19182 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19182 **[Test build #3921 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3921/testReport)** for PR 19182 at commit [`cb8e80b`](https://github.com/apache/spark/commit/

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19182 **[Test build #3921 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3921/testReport)** for PR 19182 at commit [`cb8e80b`](https://github.com/apache/spark/commit/c

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-12 Thread original-brownbear
Github user original-brownbear commented on the issue: https://github.com/apache/spark/pull/19182 @srowen done, all changes to `org.apache.hive.*` reverted :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.a

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19182 Ah OK one more subtle thing @original-brownbear -- the code you see in org/apache/hive packages is, I believe, copied from Hive. Therefore it's probably best to leave it as-is because it makes it ea

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-11 Thread original-brownbear
Github user original-brownbear commented on the issue: https://github.com/apache/spark/pull/19182 @srowen looks like we're all green :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additiona

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19182 **[Test build #3916 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3916/testReport)** for PR 19182 at commit [`b69a20b`](https://github.com/apache/spark/commit/

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19182 **[Test build #3916 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3916/testReport)** for PR 19182 at commit [`b69a20b`](https://github.com/apache/spark/commit/b

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-11 Thread original-brownbear
Github user original-brownbear commented on the issue: https://github.com/apache/spark/pull/19182 @srowen makes perfect sense => rolled back all changes to tests + publicly exposed methods (those package private ones adjusted are on non-public classes). --- -

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19182 Some of these 'throws' clauses may not be removable because they cause callers that catch the checked exception to fail to compile. Removing "throws Exception" in tests isn't obviously helpf

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19182 **[Test build #3915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3915/testReport)** for PR 19182 at commit [`3181f69`](https://github.com/apache/spark/commit/

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19182 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19182: [SPARK-21970][Core] Fix Redundant Throws Declarations in...

2017-09-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19182 **[Test build #3915 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3915/testReport)** for PR 19182 at commit [`3181f69`](https://github.com/apache/spark/commit/3