Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19188
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.ap
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19188
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81745/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81745 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81745/testReport)**
for PR 19188 at commit
[`b543e71`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81745 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81745/testReport)**
for PR 19188 at commit
[`b543e71`](https://github.com/apache/spark/commit/b5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81740/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81740 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81740/testReport)**
for PR 19188 at commit
[`c957e47`](https://github.com/apache/spark/commit/c
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81740 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81740/testReport)**
for PR 19188 at commit
[`c957e47`](https://github.com/apache/spark/commit/c9
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19188
@gatorsmile could u check? Thanks~
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-m
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81703/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81703 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81703/testReport)**
for PR 19188 at commit
[`cc11163`](https://github.com/apache/spark/commit/c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81702/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81702/testReport)**
for PR 19188 at commit
[`be1a199`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81701/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81701/testReport)**
for PR 19188 at commit
[`12767bc`](https://github.com/apache/spark/commit/1
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81703/testReport)**
for PR 19188 at commit
[`cc11163`](https://github.com/apache/spark/commit/cc
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19188
hmmm. ok, currently, we have two options only, so I feel okay to keep it
now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@s
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19188
But looks like current `TPCDSQueryBenchmarkArguments` is not good to test
individually...
---
-
To unsubscribe, e-mail: reviews-u
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19188
Yeah, it's good if you can add one.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19188
better to add tests for `TPCDSQueryBenchmarkArguments`? we have tests for
`SparkSubmitArguments` in `SparkSubmitSuite` though.
---
--
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19188
LGTM with few minor comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19188
Also, I manually checked if it worked.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81702/testReport)**
for PR 19188 at commit
[`be1a199`](https://github.com/apache/spark/commit/be
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81701/testReport)**
for PR 19188 at commit
[`12767bc`](https://github.com/apache/spark/commit/12
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19188
ok, I'll update in a day! Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19188
This has been merged. @maropu Could you update this PR? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81637/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81637 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81637/testReport)**
for PR 19188 at commit
[`322c335`](https://github.com/apache/spark/commit/3
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81637 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81637/testReport)**
for PR 19188 at commit
[`322c335`](https://github.com/apache/spark/commit/32
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81633/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81633 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81633/testReport)**
for PR 19188 at commit
[`4665e85`](https://github.com/apache/spark/commit/4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19188
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19188
**[Test build #81633 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81633/testReport)**
for PR 19188 at commit
[`4665e85`](https://github.com/apache/spark/commit/46
39 matches
Mail list logo