Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19256
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19256
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19256
**[Test build #81848 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81848/testReport)**
for PR 19256 at commit
[`7b9d6fc`](https://github.com/apache/spark/commit/7b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19256
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19256
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81848/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19256
**[Test build #81848 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81848/testReport)**
for PR 19256 at commit
[`7b9d6fc`](https://github.com/apache/spark/commit/7
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19256
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19256
**[Test build #81859 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81859/testReport)**
for PR 19256 at commit
[`7b9d6fc`](https://github.com/apache/spark/commit/7b
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19256
BTW, could you update the PR title?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19256
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19256
**[Test build #81859 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81859/testReport)**
for PR 19256 at commit
[`7b9d6fc`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19256
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81859/
Test FAILed.
---
Github user huaxingao commented on the issue:
https://github.com/apache/spark/pull/19256
Thanks @gatorsmile
I will change both the implementation and the PR title.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19256
Let me correct what I said above. The logics should be
> If any dialect's `isCascadingTruncateTable` returns `true`, we should
return `true`.
---
-
Github user huaxingao commented on the issue:
https://github.com/apache/spark/pull/19256
Thanks @gatorsmile
Does the following logic look good to you?
```
if(any dialect's isCascadingTruncateTable returns true)
return Some(true)
else
if (any dialect's isCasc
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19256
It looks good, but the actual code should be very simple if you are writing
using the Scala way
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19256
**[Test build #81898 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81898/testReport)**
for PR 19256 at commit
[`bd8e2b9`](https://github.com/apache/spark/commit/bd
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19256
LGTM pending Jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19256
**[Test build #81898 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81898/testReport)**
for PR 19256 at commit
[`bd8e2b9`](https://github.com/apache/spark/commit/b
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81898/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19256
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19256
Thanks! Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: r
Github user huaxingao commented on the issue:
https://github.com/apache/spark/pull/19256
@gatorsmile Thanks a lot for your help!!!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional com
23 matches
Mail list logo
