[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-10-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19360 Let's leave this closed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-10-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19360 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-10-08 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19360 @HyukjinKwon The problem of the PR you follow, I do not care, I will close this PR. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-09-28 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19360 I was trying to find out more not used --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19360 Shall we close this one for now then? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-09-28 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19360 Okay, I accept your opinion --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19360 We could find like you did now. Otherwise, we could suggest to fix these instances in another PR from other guys fixing them. I personally don't support to open each PR for these if it is not

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-09-28 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19360 How do you find other similar mistakes? Of course, found a immediately resolved, or behind the code more and more chaos ---

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19360 Let's buffer such things and flush it in a batch rather than arbitrarily and individually. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-09-27 Thread guoxiaolongzte
Github user guoxiaolongzte commented on the issue: https://github.com/apache/spark/pull/19360 @srowen Because i was just studying the source code here. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-09-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19360 They aren't used, but I do not think you should focus on opening JIRAs and PRs for each of these individually. --- - To

[GitHub] spark issue #19360: [SPARK-22139][CORE]Remove the variable which is never us...

2017-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19360 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional