[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-10-08 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19369 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-10-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19369 **[Test build #3942 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3942/testReport)** for PR 19369 at commit

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-10-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19369 **[Test build #3942 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3942/testReport)** for PR 19369 at commit

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-10-05 Thread superbobry
Github user superbobry commented on the issue: https://github.com/apache/spark/pull/19369 I've fixed the failing `DiskStoreSuite` and ensured the other two suites also pass fine. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-10-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19369 **[Test build #3941 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3941/testReport)** for PR 19369 at commit

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-10-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19369 **[Test build #3941 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3941/testReport)** for PR 19369 at commit

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-09-28 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19369 Yeah, not surprised that it's due to a test that relies a little too much on how data happens to hash or partition. The fix looks OK. ---

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-09-28 Thread superbobry
Github user superbobry commented on the issue: https://github.com/apache/spark/pull/19369 I've looked at the allocation profile of the sample, it does indeed contain strings from other sources, so the heap histogram is not representative. However, the allocations from

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-09-27 Thread superbobry
Github user superbobry commented on the issue: https://github.com/apache/spark/pull/19369 Will have a look at the failing tests tomorrow and also have a look at the origins of the strings in the sample above. --- -

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19369 **[Test build #3936 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3936/testReport)** for PR 19369 at commit

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-09-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19369 I don't know that this is evidence that the allocations came from this bit of code, but, still it seems like a win. --- - To

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-09-27 Thread superbobry
Github user superbobry commented on the issue: https://github.com/apache/spark/pull/19369 > Yes, if you have evidence this is a hotspot, then this does look like a valid fix. I don't think it's a hotspot (otherwise it would have probably been reported long before). I do

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-09-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19369 **[Test build #3936 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3936/testReport)** for PR 19369 at commit

[GitHub] spark issue #19369: [SPARK-22147][CORE] Removed redundant allocations from B...

2017-09-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19369 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional