Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/19640
JS is not really my thing, but other have reviewed and seem ok. I'm fine
with this being done client-side.
Merging to master.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
It's a pure UI change so no compatibility issues. The new UI LGTM
---
-
To unsubscribe, e-mail:
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19640
I'm still not 100% convinced this is the best change, but the
implementation LGTM.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83902/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83902 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83902/testReport)**
for PR 19640 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83900/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83900/testReport)**
for PR 19640 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83902 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83902/testReport)**
for PR 19640 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83900/testReport)**
for PR 19640 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83868/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83868 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83868/testReport)**
for PR 19640 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83868 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83868/testReport)**
for PR 19640 at commit
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83848/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83848 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83848/testReport)**
for PR 19640 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83848 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83848/testReport)**
for PR 19640 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
sorry, I mean we should follow the format we use in completed, started...
---
-
To unsubscribe, e-mail:
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
Generated by the `toLocaleTimeString ()` method:
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
why it has `PM` postfix at the end?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
It looks like this:
https://user-images.githubusercontent.com/5399861/32779430-be47bac8-c978-11e7-97d1-fd3e3db9166f.png;>
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
maybe we can move `formatDate` to util and use it there.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
It is client local time zone:
https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/historypage-common.js#L22
But the format is `11/14/2017,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
how about `Client local time zone`? any better ideas?
BTW the `last updated` timestamp string at the beginning, which time zone
it is?
---
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/19640
How about this?
https://user-images.githubusercontent.com/5399861/32773266-8f9c1ce2-c963-11e7-8b9d-dba785f71772.png;>
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
The timezone is decided by the client(browser), which means it will be same
for all timestamp strings in this browser, maybe put it in the title is more
concise?
---
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/19640
IMO we'd better have timeZone after each datetime string, that would avoid
a lot of confusions.
---
-
To unsubscribe,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83813/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83813 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83813/testReport)**
for PR 19640 at commit
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19640
I'd be ok with that
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19640
How about we add the timezone abbreviation in the title? e.g.
`started(PST)`, `completed(PST)`
---
-
To unsubscribe, e-mail:
Github user ajbozarth commented on the issue:
https://github.com/apache/spark/pull/19640
I would tend to agree with @srowen on this, but from an implication side
this is pretty good. I would suggest adding the timezone abbreviation to the
end so the user knows it's in local time not
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83813 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83813/testReport)**
for PR 19640 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83727/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19640
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19640
**[Test build #83727 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83727/testReport)**
for PR 19640 at commit
40 matches
Mail list logo
