[GitHub] spark issue #19659: [SPARK-19668][ML] Multiple NGram sizes

Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19659 @holdenk I can take this up if this is needed. Let me know. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apac

[GitHub] spark issue #19659: [SPARK-19668][ML] Multiple NGram sizes

Github user mpetruska commented on the issue: https://github.com/apache/spark/pull/19659 No, I'm not working on this one, the feature seems to lack any real interest. We can close it, if you like. --- - To unsubscri

[GitHub] spark issue #19659: [SPARK-19668][ML] Multiple NGram sizes

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19659 Is this a thing you are still working on @mpetruska ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For addi

[GitHub] spark issue #19659: [SPARK-19668][ML] Multiple NGram sizes

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19659 So SparkR will have to be separate, I'm going to cc @felixcheung , I don't know if we currently expose this functionality in the Spark R side. As for the @Since attributes you choose them ba

[GitHub] spark issue #19659: [SPARK-19668][ML] Multiple NGram sizes

Github user mpetruska commented on the issue: https://github.com/apache/spark/pull/19659 Also, will this work in SparkR, or do I need to add some code/configuration to expose the functionality to [R]? --- - To unsub

[GitHub] spark issue #19659: [SPARK-19668][ML] Multiple NGram sizes

Github user mpetruska commented on the issue: https://github.com/apache/spark/pull/19659 @holdenk : Thanks for the review. Fixed/addressed your comments, can you please have another look? Also I'd like some help with regards to the `@Since` attributes; how should I fill them in

[GitHub] spark issue #19659: [SPARK-19668][ML] Multiple NGram sizes

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19659 Let me CC @MLnick as well. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: re

[GitHub] spark issue #19659: [SPARK-19668][ML] Multiple NGram sizes

Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19659 Thanks for working on this. Jenkins OK to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19659: [SPARK-19668][ML] Multiple NGram sizes

Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19659 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional