Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
@cloud-fan Do you have some other comments on this? Or shall we close this?
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
ping @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
ping @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
Do you mean we manually run `ReuseExchange` after the registration of
exchanges?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19756
can we run `ReuseExchange` twice?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
The exchanges only register with `ExchangeCoordinator` after query
transformation. So during transformation, we don't know if two
`ExchangeCoordinator` have the same exchanges.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19756
then can't we correctly implement `equals` for the coordinator?
---
-
To unsubscribe, e-mail:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
My first thought is also to fix `Exchange.sameResult`. But I realize soon
that it is not a right fix. The reason is, the results of coordinated exchanges
are dependent with all exchanges coordinated
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19756
can you also explain the cause of this bug instead of just describing the
bug? By looking at your code, seems we can just fix the `Exchange.sameResult`
to exclude the coordinator?
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
ping @cloud-fan Please take a look. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/19756
cc @cloud-fan for review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83894/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19756
**[Test build #83894 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83894/testReport)**
for PR 19756 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19756
**[Test build #83894 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83894/testReport)**
for PR 19756 at commit
16 matches
Mail list logo
