[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2018-01-03 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20119 OK, I will do it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2018-01-03 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20119 > @zsxwing maybe we only need to fix above two points related to external shuffle service, what do you think? @jerryshao sgtm. Could you submit a PR? ---

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2018-01-03 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20119 @zsxwing maybe we only need to fix above two points related to external shuffle service, what do you think? --- - To

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2018-01-02 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20119 Sorry I haven't checked the details, let me take a look at it. The changes I made was trying to fix memory issue for shuffle (especially external shuffle service), this issue was occurred in our

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2018-01-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20119 let's also cc the author. @jerryshao do you know if there is a way to fix the regression? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2017-12-29 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20119 Thanks! Merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2017-12-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20119 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2017-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20119 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85532/ Test PASSed. ---

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2017-12-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20119 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2017-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20119 **[Test build #85532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85532/testReport)** for PR 20119 at commit

[GitHub] spark issue #20119: [SPARK-21475][Core]Revert "[SPARK-21475][CORE] Use NIO's...

2017-12-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20119 **[Test build #85532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85532/testReport)** for PR 20119 at commit