Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20137
Thanks! Merged to master and 2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85657/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85657 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85657/testReport)**
for PR 20137 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85657 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85657/testReport)**
for PR 20137 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85655/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85655 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85655/testReport)**
for PR 20137 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85655 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85655/testReport)**
for PR 20137 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
Looks fine to me otherwise BTW.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
cc @mgaido91 since you touched related codes lately.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85636/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85636 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85636/testReport)**
for PR 20137 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85636 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85636/testReport)**
for PR 20137 at commit
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20137
@HyukjinKwon Thank you for your comment!
cc @ueshin @cloud-fan
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85625/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85625 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85625/testReport)**
for PR 20137 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
Thank you for bearing with me @gatorsmile.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85625 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85625/testReport)**
for PR 20137 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
> BTW, this PR is not just for `asNondeterministic()`. We have the same
issue for the deterministic UDFs.
Yup, the fix for deterministic UDFs seem fine but the change about
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85619/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85619 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85619/testReport)**
for PR 20137 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
With this diff:
```diff
--- a/python/pyspark/sql/udf.py
+++ b/python/pyspark/sql/udf.py
@@ -173,4 +173,4 @@ class UserDefinedFunction(object):
.. versionadded::
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
With this diff:
```diff
diff --git a/python/pyspark/sql/udf.py b/python/pyspark/sql/udf.py
index 54b5a8656e1..24de9839e90 100644
--- a/python/pyspark/sql/udf.py
+++
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20137
Take your time. I will not be online in the next two hours.
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
Let me test it and be back soon.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20137
Can you run the command?
```
help(udf(lambda: 1, "integer").asNondeterministic())
```
---
-
To unsubscribe,
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
but if we do
```diff
+wrapper.asNondeterministic = lambda:
self.asNondeterministic()._wrapped()
```
I think it will still show a proper pydoc ..
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20137
I am not against anything, but the outputs of the following two are
inconsistent. It looks confusing to end users.
```
help(udf(lambda: 1, "integer").asNondeterministic())
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85619 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85619/testReport)**
for PR 20137 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
Ur, @gatorsmile, then, we will return a wrapped function from
`UserDefinedFunction(). asNondeterministic`. Mind if I ask to elaborate why? I
thought `UserDefinedFunction` should still return
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20137
@HyukjinKwon We need to fix `asNondeterministic `
```
def asNondeterministic(self):
"""
Updates UserDefinedFunction to nondeterministic.
..
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20137
Hey @gatorsmile, I was just looking into this now. How about we have
`_unwrapped` for wrapped function and then we return wrapped function from
wrapped function and `UserDefinedFunction` from
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85618/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85618/testReport)**
for PR 20137 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85618/testReport)**
for PR 20137 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85617 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85617/testReport)**
for PR 20137 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85617/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85617 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85617/testReport)**
for PR 20137 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85616/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85616 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85616/testReport)**
for PR 20137 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85616 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85616/testReport)**
for PR 20137 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85608/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85608 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85608/testReport)**
for PR 20137 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85607 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85607/testReport)**
for PR 20137 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20137
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85607/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85608 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85608/testReport)**
for PR 20137 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20137
**[Test build #85607 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85607/testReport)**
for PR 20137 at commit
57 matches
Mail list logo
