Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20168
Overall looks good to me. Just some minor comments regarding with code
comments and naming.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86156/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86156 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86156/testReport)**
for PR 20168 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20168
Btw, I think this isn't only to add non-integer image formats. So the PR
title may be changed too. Like "Add ImageSchema support for all OpenCV image
types"?
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86156 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86156/testReport)**
for PR 20168 at commit
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/20168
@MrBago @tomasatdatabricks the changes look good to me, I went through
everything one more time, I'll sign off as soon as the python tests are fixed
(it looks like there were some style
Github user imatiach-msft commented on the issue:
https://github.com/apache/spark/pull/20168
@MrBago @tomasatdatabricks I think the breaking changes are fine, the code
was marked experimental and it is expected that the interfaces will change a
lot initially based on early feedback.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86149/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86149 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86149/testReport)**
for PR 20168 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86149 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86149/testReport)**
for PR 20168 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86148/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86148 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86148/testReport)**
for PR 20168 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86148 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86148/testReport)**
for PR 20168 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86061/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86061 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86061/testReport)**
for PR 20168 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86061 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86061/testReport)**
for PR 20168 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86059/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86059 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86059/testReport)**
for PR 20168 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #86059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86059/testReport)**
for PR 20168 at commit
Github user tomasatdatabricks commented on the issue:
https://github.com/apache/spark/pull/20168
@MrBago Here is the description of the breaking changes.
ImageSchema.ocvTypes and ImageSchema.javaOcvTypes changed types from
Map[String,Int] to list of OpenCvType.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85884/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #85884 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85884/testReport)**
for PR 20168 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #85884 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85884/testReport)**
for PR 20168 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85880/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #85880 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85880/testReport)**
for PR 20168 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #85880 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85880/testReport)**
for PR 20168 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85878/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20168
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #85878 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85878/testReport)**
for PR 20168 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20168
**[Test build #85878 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85878/testReport)**
for PR 20168 at commit
37 matches
Mail list logo
