[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20187 Merging to master / 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20187 ``` Discovery starting. Discovery completed in 191 milliseconds. Run starting. Expected test count is: 8 KubernetesSuite: - Run SparkPi with no resources - Run SparkPi with a

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20187 Let me know how those tests go and then I'll merge this. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20187 @liyinan926 -- not yet, will be running them shortly. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20187 @foxish have you run the integration tests against this on both minikube and GKE? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread bowei
Github user bowei commented on the issue: https://github.com/apache/spark/pull/20187 Confirmed -- the FQDN is not going to work on clusters that have a custom cluster suffix. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20187 cc/ @zihongz @bowei from K8s networking - can you guys confirm that using `..svc` is strictly better than using the FQDN which made an assumption of the dns zone (cluster.local)? ---

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20187 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85805/ Test PASSed. ---

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20187 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20187 **[Test build #85805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85805/testReport)** for PR 20187 at commit

[GitHub] spark issue #20187: [SPARK-22992][K8S] Remove assumption of the DNS domain

2018-01-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20187 **[Test build #85805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85805/testReport)** for PR 20187 at commit