[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 Opened https://github.com/apache/spark/pull/20322. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20296 Yes, we can't change the target branch of a PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 I think one of us should do it then - in the interest of time and making the next RC. It looks like the PR author may be in a different timezone. ---

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20296 Normally you should close this and open another PR against the master branch. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 That would explain also why the tests aren't running. @sameeragarwal/@vanzin, can someone with manual merge powers retarget this to the master branch? ---

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 Good point. @andrusha, can you target it to master instead? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20296 Why is this PR against 2.3 but not master? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20296 @ssuchter should I wait for your tests to run? Normal PRB won't touch this file, so I'm leaning towards just pushing this. --- -

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread ssuchter
Github user ssuchter commented on the issue: https://github.com/apache/spark/pull/20296 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 LGTM, looks like we missed this when unifying the docker images. Would be good to get this into 2.3.0 as well. --- - To

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/20296 Thanks for fixing this! LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 cc/ @vanzin @felixcheung @liyinan926 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20296 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20296 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20296 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20296: [SPARK-23133][K8S] Fix passing java options to Executor

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20296 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional