[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-02 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20703 @zsxwing I didn't know that the original design of structured streaming is not to share the Kafka consumers. I'll close this PR and take a deeper look at the situation. ---

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/20703 I completely agree with @zsxwing, let understand what the issue is rather than covering it up with a workaround. We should not run into such issue at all. ---

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread jose-torres
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20703 I didn't realize that spark.streaming.kafka.consumer.cache.enabled was an existing property in dstreams. I don't have any objection to porting the flag and its documentation as-is to structured

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20703 > Is this PR intended for backport? Yeah, I think it should be backported. > In master, I think we need to also fix CachedKafkaConsumer to not share consumers when it's

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread jose-torres
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20703 Is this PR intended for backport? In master, I think we need to also fix CachedKafkaConsumer to not share consumers when it's unsafe. ---

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20703 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87846/ Test PASSed. ---

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20703 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20703 **[Test build #87846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87846/testReport)** for PR 20703 at commit

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20703 also cc @tdas --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20703 **[Test build #87846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87846/testReport)** for PR 20703 at commit

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20703 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20703 add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20703 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20703 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20703: [SPARK-19185][SS] Make Kafka consumer cache configurable

2018-03-01 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20703 cc @vanzin @zsxwing @jose-torres @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For