Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20706
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20706
Any more comments?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87984/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87984 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87984/testReport)**
for PR 20706 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1297/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87984 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87984/testReport)**
for PR 20706 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20706
@jiangxb1987 keeping dead code around will inevitably lead to code rot. If
there is not use for something then we should remove it. Adding things back is
not a problem.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87863/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87863 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87863/testReport)**
for PR 20706 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87863 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87863/testReport)**
for PR 20706 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1211/
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20706
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20706
I'm almost sure there's a bug somewhere for that flaky test, but if there
isn't I'll file one.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87855/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87855 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87855/testReport)**
for PR 20706 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87853 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87853/testReport)**
for PR 20706 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87853/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87850/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87850 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87850/testReport)**
for PR 20706 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1206/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87855 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87855/testReport)**
for PR 20706 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20706
Ok, I'm going to revert the `createDirectory` changes because the
`Files.createTempDirectory` api forces permissions to `700`, and secure YARN
requires that the block manager directories respect the
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20706
> I do not know whether this change only affects the test cases.
I do, because I checked. The tests were using the API incorrectly,
actually, and could leave garbage outside the temp dirs,
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20706
Unfortunately, I do not know whether this change only affects the test
cases. Any behavior change require a conf. We can get rid of it later if nobody
hit the issue.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87853 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87853/testReport)**
for PR 20706 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1204/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20706
> The behavior changes have to be separated from the code refactoring.
The behavior change only affects tests, which have been fixed in this PR.
---
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20706
The behavior changes have to be separated from the code refactoring.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20706
**[Test build #87850 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87850/testReport)**
for PR 20706 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1201/
40 matches
Mail list logo
