Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20937
@rxin, I am sorry for pinging here and there. Are you positive on this
feature too? Just wanted to be sure before going ahead.
---
Github user brkyvz commented on the issue:
https://github.com/apache/spark/pull/20937
yes, please do
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/20937
@brkyvz should I add tests that was removed by
https://github.com/apache/spark/pull/20614 ? I guess they came from real
customer's use case. The tests should pass if `encoding` is explicitly set to
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20937
I am asking this only because I don't feel strong on this (but am okay).
So, I just want to check other committers like this one ahead.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20937
@cloud-fan and @gatorsmile, just for doubly sure, you guys are at least
positive on this feature itself, right?
---
-
To
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/20937
@HyukjinKwon I blacklisted the `UTF-16` and `UTF-32` encodings, and renamed
`charset` to `encoding`. Please, have a look at it again.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88783/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #88783 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88783/testReport)**
for PR 20937 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88782/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #88782 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88782/testReport)**
for PR 20937 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #88783 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88783/testReport)**
for PR 20937 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #88782 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88782/testReport)**
for PR 20937 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20937
Others are mostly nits except
https://github.com/apache/spark/pull/20937#discussion_r178426866. Let's talk
there more.
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20937
Others are mostly nits except
https://github.com/apache/spark/pull/20937#discussion_r178426866. Let's talk
there more.
---
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/20937
@HyukjinKwon @cloud-fan @gatorsmile Please, have a look at this PR and
https://github.com/MaxGekk/spark-1/pull/2
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88714/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #88714 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88714/testReport)**
for PR 20937 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #88714 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88714/testReport)**
for PR 20937 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #88710 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88710/testReport)**
for PR 20937 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88710/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20937
**[Test build #88710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88710/testReport)**
for PR 20937 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20937
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
26 matches
Mail list logo
