Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21014
Merging to master / 2.3 / 2.2.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89896/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21014
**[Test build #89896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89896/testReport)**
for PR 21014 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21014
**[Test build #89896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89896/testReport)**
for PR 21014 at commit
Github user tiboun commented on the issue:
https://github.com/apache/spark/pull/21014
Ah yes, I understand what you mean, I'm going to fix it right now
---
-
To unsubscribe, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21014
What I meant was to actually do `options.map(shellEscape)` in the return
line.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89892/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21014
**[Test build #89892 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89892/testReport)**
for PR 21014 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21014
**[Test build #89892 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89892/testReport)**
for PR 21014 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21014
Wouldn't it be simpler and safer to just `shellEscape` everything in
`options` before returning it?
---
-
To unsubscribe,
Github user tiboun commented on the issue:
https://github.com/apache/spark/pull/21014
Hi, do I need to do something else in order for this PR to be merged ?
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89180/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21014
**[Test build #89180 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89180/testReport)**
for PR 21014 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21014
**[Test build #89180 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89180/testReport)**
for PR 21014 at commit
Github user tiboun commented on the issue:
https://github.com/apache/spark/pull/21014
Ah yes, correct Vanzin, I didn't think about that use case. So I will apply
shellEscape for both in this PR.
---
-
To
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21014
> mainClass doesn't need the same because space is not allowed
It may have dollar signs and other things that the shell might want to
interpret.
---
Github user tiboun commented on the issue:
https://github.com/apache/spark/pull/21014
IMO, mainClass doesn't need the same because space is not allowed but
pyFiles may have the same fix because it's a path. Do you want me to apply the
shellEscape as well for pyFiles?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89077/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21014
**[Test build #89077 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89077/testReport)**
for PR 21014 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21014
**[Test build #89077 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89077/testReport)**
for PR 21014 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21014
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21014
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
27 matches
Mail list logo
