[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21141 Thank you, @HyukjinKwon! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-30 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21141 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-30 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21141 Thank you, @bersprockets . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-ma

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-30 Thread bersprockets
Github user bersprockets commented on the issue: https://github.com/apache/spark/pull/21141 My experience here is limited. Still, it also looks good to me. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apac

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21141 Thank you for review and approval, @HyukjinKwon . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For ad

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21141 The PR is updated now. Could you review this again, @holdenk, @HyukjinKwon , @felixcheung , @bersprockets ? --- - To unsub

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89974/ Test PASSed. ---

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21141 **[Test build #89974 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89974/testReport)** for PR 21141 at commit [`271e152`](https://github.com/apache/spark/commit/2

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2748/ Tes

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21141 **[Test build #89974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89974/testReport)** for PR 21141 at commit [`271e152`](https://github.com/apache/spark/commit/27

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21141 I see. Thanks, @bersprockets . I'll proceed this PR according to your and other peoples comments. --- - To unsubscribe, e-

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-27 Thread bersprockets
Github user bersprockets commented on the issue: https://github.com/apache/spark/pull/21141 @dongjoon-hyun @HyukjinKwon My PR is no longer addressing the issue described its associated Jira [(SPARK-23776),](https://issues.apache.org/jira/browse/SPARK-23776) which is that developers d

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21141 I am okay either way but I thought @bersprockets agreed up on doing this separately here? Doctests stuff need more looks and I think this one alone can be merged separately. @bersprocke

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21141 Thank you for review, @HyukjinKwon , @holdenk , @bersprockets . I didn't notice SPARK-23776 when I chose SPARK-23853 . I think we can merge those PRs now. @bersprockets . Coul

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-26 Thread bersprockets
Github user bersprockets commented on the issue: https://github.com/apache/spark/pull/21141 @holdenk Yes, see [this jira](https://issues.apache.org/jira/browse/SPARK-23776). If you build with sbt, you need to also run 'build/sbt sql/test:compile' to get udfs from the test files. --

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-26 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/21141 Also weirdly when I run this locally without hive built I get some UDF registration exceptions (could be unrelated) - do you get that? --- -

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21141 **[Test build #89782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89782/testReport)** for PR 21141 at commit [`54fdfd0`](https://github.com/apache/spark/commit/5

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89782/ Test PASSed. ---

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21141 Actually, I think https://github.com/apache/spark/pull/20909 tries to fix the same thing. If both fix the (almost) same things, this way looks a bit more preferable. @bersprockets, If

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/21141 Great, thank you! I'll review it this Thursday :) On Tue, Apr 24, 2018 at 4:38 AM, UCB AMPLab wrote: > Merged build finished. Test FAILed. > > — > You are receivin

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89781/ Test FAILed. ---

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21141 **[Test build #89781 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89781/testReport)** for PR 21141 at commit [`dc81cf9`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2628/ Tes

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21141 **[Test build #89782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89782/testReport)** for PR 21141 at commit [`54fdfd0`](https://github.com/apache/spark/commit/54

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21141 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2627/ Tes

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21141 **[Test build #89781 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89781/testReport)** for PR 21141 at commit [`dc81cf9`](https://github.com/apache/spark/commit/dc

[GitHub] spark issue #21141: [SPARK-23853][PYSPARK][TEST] Run Hive-related PySpark te...

2018-04-24 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21141 Hi, @holdenk . Could you review this PR when you have some time? --- - To unsubscribe, e-mail: reviews-unsubscr...@spar