Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3047/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90378/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21145
**[Test build #90378 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90378/testReport)**
for PR 21145 at commit
[`560ad6a`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21145
**[Test build #90378 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90378/testReport)**
for PR 21145 at commit
[`560ad6a`](https://github.com/apache/spark/commit/56
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90334/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21145
**[Test build #90334 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90334/testReport)**
for PR 21145 at commit
[`250c1de`](https://github.com/apache/spark/commit/2
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3011/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21145
**[Test build #90334 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90334/testReport)**
for PR 21145 at commit
[`250c1de`](https://github.com/apache/spark/commit/25
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21145
@gatorsmile, the Spark UI has used the term "task" for years to refer to
the same thing. I don't think it is unreasonable to use the same term.
![tasks](https://user-images.githubusercontent
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/21145
I don't see the problem with the name ReadTask. In RDDs, we call the
serializable representation of a partition for distribution to executors just
Partition, and I've always found this pretty in
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21145
@gengliangwang, we can follow up with a rename for the streaming classes
that already use this API. But there is no need to do that right now and make
this commit larger.
I think I've alread
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/21145
Either names are not perfect.
It is not a real task, and it has a method name `createDataReader`, while
there is `createDataWriter` in `DataWriterFactory`.
It is not a factory (design
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21145
I agree this is not a real factory, but it's not a real task either. I feel
something like `DataReaderHolder` or `ReadTaskDescriptor` should be better.
also cc @rxin @marmbrus
---
Github user henryr commented on the issue:
https://github.com/apache/spark/pull/21145
I don't mind `ReadTask`. It's imperfect because 'task' implies that this is
a thing that can be executed, whereas this interface doesn't have a way to pass
control to the task object. It's more like
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21145
@cloud-fan and @henryr, do you have an opinion about naming here?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.o
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21145
I think `ReadTask` is fine. That name does not imply that you can use the
object itself to read, but it does correctly show that it is one task in a
larger operation. I think the name implies that it
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21145
It sounds like both `ReadTask ` and `DataReaderFactory ` are not a good
name here. Any better idea?
---
-
To unsubscribe, e-
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21145
@arunmahadevan, the problem is that the current naming is misleading. This
is not a factory (it only produces one specific reader) and it does not have
the same lifecycle as the write-side factory. U
Github user arunmahadevan commented on the issue:
https://github.com/apache/spark/pull/21145
IMO, its better to keep it the current way.
`DataReaderFactory` implies that its something that produces `DataReader`
which it does, whereas `ReadTask` is gives a notion that it does
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89848/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21145
**[Test build #89848 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89848/testReport)**
for PR 21145 at commit
[`609ec14`](https://github.com/apache/spark/commit/6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2674/
Tes
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21145
**[Test build #89848 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89848/testReport)**
for PR 21145 at commit
[`609ec14`](https://github.com/apache/spark/commit/60
29 matches
Mail list logo