[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21194 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-06-06 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21194 @zsxwing Thanks for dropping by. This patch is about fixing the rate ramp up when `rowsPerSecond <= rampUpTime`, which makes the Rate Source produce no data until `rampUpTime` (See [SPARK-24046](htt

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-06-06 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/21194 This is just a feature to warm up JVMs. Why do we need a smooth increasing for this? --- - To unsubscribe, e-mail: reviews-unsub

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-06-06 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21194 @felixcheung Could you review pls ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-23 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21194 @holdenk as we discussed in Strata, it would be great if you could give me your opinion on the approach taken in this PR. --- - To

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21194 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-03 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21194 pinging @zsxwing: as the original author of the `RateSourceProvider`, could you review this PR? --- - To unsubscribe, e-mail: rev

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-01 Thread maasg
Github user maasg commented on the issue: https://github.com/apache/spark/pull/21194 @xuanyuanking thanks for the review. I understand that the changes are broader than what the ticket might imply, but I believe the new implementation is much simpler to understand and delivers an impr

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21194 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21194: [SPARK-24046][SS] Fix rate source when rowsPerSecond <= ...

2018-05-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21194 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional