Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
thanks @vanzin.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21268
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
@vanzin thanks for your review.
I checked the comment you mentioned. My understanding is that the property
`spark.ui.proxyBase` is used by Oozie and in particular it is set bu the AM of
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90698/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21268
**[Test build #90698 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90698/testReport)**
for PR 21268 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3275/
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21268
BTW you could probably avoid the plumbing (and noise) by using a
DynamicVariable but that feels too hacky and brittle, so I actually prefer this.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21268
**[Test build #90698 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90698/testReport)**
for PR 21268 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21268
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/21268
I took a look and it looks ok. I'm just confused about the YARN comments,
since the AM does not set anything (the YARN NM will set the
`APPLICATION_WEB_PROXY_BASE` env variable, but nothing else
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
@vanzin do you happen to have any time for checking this please? Thanks.
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
@vanzin may you please take a look at this too? Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
@jerryshao I don't think we can miss them. The main change here is the
`uiRoot` requires the `request` object. So if you miss to provide it the
object, it doesn't compile. All the other changes
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21268
I'm still thinking this change requires so many updates across the whole
project, and we may miss it in future if someone add new codes. Though I'm not
familiar with knox, my question is that
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
Thanks for your comment @jerryshao. Unfortunately I don't think so. Since
through the SHS you can access all the other pages, all of them have to support
the proper detection of the proxy base as
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21268
The changes here seems affect so many places, I'm wondering if there's any
other way to minimize the changes?
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90369/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21268
**[Test build #90369 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90369/testReport)**
for PR 21268 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
@nrchakradhar if the load balancer fills the header `X-Forwarded-Context`
with the proper base path, then this will work.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3040/
Github user nrchakradhar commented on the issue:
https://github.com/apache/spark/pull/21268
@mgaido91 Just a query. Is this specific to Knox only or will it work when
the HistoryServer UI is proxied by different load balancer?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21268
**[Test build #90369 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90369/testReport)**
for PR 21268 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90366/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21268
**[Test build #90366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90366/testReport)**
for PR 21268 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3038/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21268
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21268
**[Test build #90366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90366/testReport)**
for PR 21268 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
@jerryshao may you please review this when you have time? Thanks.
---
-
To unsubscribe, e-mail:
33 matches
Mail list logo
