Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21481
thanks, merging to master/2.3!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91922/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21481
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21481
**[Test build #91922 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91922/testReport)**
for PR 21481 at commit
[`a87c417`](https://github.com/apache/spark/commit/a
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
@cloud-fan addressed all of the possible integer overflows detected by
SpotBugs.
---
-
To unsubscribe, e-mail: reviews-unsubscr...
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21481
@kiszk when you were running findBugs locally, did you find more overflow
bugs that are not present in this PR? Let's put all discovered overflow bugs in
this PR and have another PR to integrate
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
Thank you for your comment. I will create another PR for integrating
findBugs/SpotBugs into maven.
---
-
To unsubscribe, e-mail: r
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/21481
Let's merge this as-is and do the build improvements in a separate PR.
That's important because we may want to backport the overflow fix to
maintenance branches and may want to do so independent o
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
Since I found an plug-in for maven, I will also include a patch to add
findBugs/SpotBugs into maven in this PR.
---
-
To unsubscri
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
Since it is Java bytecode analysis, it is available for Scala code, too.
In my quick test, findBugs overlooked a possible overflow. On the other
hand, findBugs found another redundant null check.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21481
is findBugs available for scala code as well?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
@JoshRosen @cloud-fan
Here is an update.
I have just apply `findBugs` to `OffHeapColumnVector.java` and
`UnsafeArrayData.java`.
In `OffHeapColumnVector.java`, most of possible overflo
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
Good questions.
For 2, at first I found one of these issues when I looked at a file. Then,
I ran `grep` command with `long .*=.*\*` and `long .*=.*\+` in `.java` file.
Then, I picked them up
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21481
+1 on @JoshRosen 's ideas.
I've already seen several overflow fixes from @kiszk , it will be good if
we have some tools to check it, even we need to run the tool manually. One idea
may be
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/21481
Hey @kiszk, thanks for tracking this down. This change looks good to me.
I have a couple of questions, mostly aimed towards figuring out how we can
categorically solve this problem:
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spa
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21481
cc @ueshin @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21481
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91404/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21481
**[Test build #91404 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91404/testReport)**
for PR 21481 at commit
[`324fd5c`](https://github.com/apache/spark/commit/3
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21481
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3768/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21481
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21481
**[Test build #91404 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91404/testReport)**
for PR 21481 at commit
[`324fd5c`](https://github.com/apache/spark/commit/32
23 matches
Mail list logo
