[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-19 Thread xueyumusic
Github user xueyumusic commented on the issue: https://github.com/apache/spark/pull/21567 I see, thanks for your review and guidance, @jiangxb1987 @maropu , I will try to add related config to doc and close this PR, thank you --- -

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-19 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21567 Overall I don't think the current logic shall be modified. However, it shall be useful to document some the configs mentioned in this PR. --- --

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92008/ Test PASSed. ---

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #92008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92008/testReport)** for PR 21567 at commit [`0dd57ea`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #92008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92008/testReport)** for PR 21567 at commit [`0dd57ea`](https://github.com/apache/spark/commit/0d

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-17 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91984 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91984/testReport)** for PR 21567 at commit [`0dd57ea`](https://github.com/apache/spark/commit/0d

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91971/ Test FAILed. ---

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91971/testReport)** for PR 21567 at commit [`a69df11`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91971/testReport)** for PR 21567 at commit [`a69df11`](https://github.com/apache/spark/commit/a6

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91964/ Test FAILed. ---

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91964 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91964/testReport)** for PR 21567 at commit [`a69df11`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91964 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91964/testReport)** for PR 21567 at commit [`a69df11`](https://github.com/apache/spark/commit/a6

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 @xueyumusic Can you fix the error first? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional command

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 cc @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21567 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91959/ Test FAILed. ---

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91959/testReport)** for PR 21567 at commit [`a8dc241`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21567 **[Test build #91959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91959/testReport)** for PR 21567 at commit [`a8dc241`](https://github.com/apache/spark/commit/a8

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21567 ok to test. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread xueyumusic
Github user xueyumusic commented on the issue: https://github.com/apache/spark/pull/21567 I have made some modification, @maropu please review the code, thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.

[GitHub] spark issue #21567: [SPARK-24560][CORE][MESOS] Fix some getTimeAsMs as getTi...

2018-06-15 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21567 Can you add tests in `SparkConfSuite`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,