Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21599
@cloud-fan I think this is just a wrong behavior (being against SQL
standard is not the only issue), so I am not sure that makes sense to have it
controlled by a config. Anyway, I agree that as it
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21599
I don't think we can change behavior like this without introducing a
config. In Spark 3.0 we will add a "strict mode" and closely follow SQL
standard. But for Spark 2.4, how about we keep the "jav
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21599
ah that's a good point. Then maybe we should keep this "java style
behavior" and add "strict mode" later.
cc @rxin @rednaxelafx
---
-
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21599
@cloud-fan ok, but then all arithmetic operations should be always
`nullable = true`. I am not sure whether this can introduce performance
regression (the additional checks are also going to worsen
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21599
I prefer returning null, and introduce a strict mode in Spark 3.0. We can
revisit all the returning null cases and think if we should fail if strict mode
is on.
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21599
kindly ping @cloud-fan @gatorsmile @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additiona
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93107/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #93107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93107/testReport)**
for PR 21599 at commit
[`7bba22f`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1009/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #93107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93107/testReport)**
for PR 21599 at commit
[`7bba22f`](https://github.com/apache/spark/commit/7b
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21599
@cloud-fan @gatorsmile @hvanhovell what do you think about deciding a
strategy about how to handle this case and try to make it happen in 2.4 as this
is a correctness bug? Thanks.
---
--
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21599
kindly ping @gatorsmile @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92216/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92216 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92216/testReport)**
for PR 21599 at commit
[`a0b862e`](https://github.com/apache/spark/commit/a
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92216/testReport)**
for PR 21599 at commit
[`a0b862e`](https://github.com/apache/spark/commit/a0
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/414/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92208/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92208 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92208/testReport)**
for PR 21599 at commit
[`ebdaf61`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/408/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92208 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92208/testReport)**
for PR 21599 at commit
[`ebdaf61`](https://github.com/apache/spark/commit/eb
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92172/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92172 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92172/testReport)**
for PR 21599 at commit
[`9c3df7d`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92172 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92172/testReport)**
for PR 21599 at commit
[`9c3df7d`](https://github.com/apache/spark/commit/9c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/378/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21599
@cloud-fan it is not a regression, it has been like that at least since
2.0...
---
-
To unsubscribe, e-mail: reviews-unsubscr..
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21599
is this a regression in Spark 2.3? which commit caused it?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
F
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21599
@cloud-fan @gatorsmile the main issue which is causing the UT failures,
now, is that since before we were allowing overflows, in aggregations we could
have an overflow eventually fixed by another o
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92140/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92140 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92140/testReport)**
for PR 21599 at commit
[`8591417`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92140 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92140/testReport)**
for PR 21599 at commit
[`8591417`](https://github.com/apache/spark/commit/85
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/358/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4254/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92133/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92133 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92133/testReport)**
for PR 21599 at commit
[`fad75fa`](https://github.com/apache/spark/commit/f
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92133 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92133/testReport)**
for PR 21599 at commit
[`fad75fa`](https://github.com/apache/spark/commit/fa
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4250/
Tes
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/354/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92132/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92132 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92132/testReport)**
for PR 21599 at commit
[`5c662f6`](https://github.com/apache/spark/commit/5
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21599
**[Test build #92132 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92132/testReport)**
for PR 21599 at commit
[`5c662f6`](https://github.com/apache/spark/commit/5c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/353/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4249/
Tes
59 matches
Mail list logo
