[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-27 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21706 hey @HyukjinKwon thanks for coming back to me on this :) I'll close the PR now, and start a thread later today on the dev mailing list ---

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-15 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21706 hey @gatorsmile, sorry to bother, could you just clarify the above? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-10 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21706 In the current Spark version I can run ```scala scala> spark.sql("SELECT 'interval 1 hour' as a").select(col("a").cast("calendarinterval")).show() ++ |

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-09 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21706 @gatorsmile @ueshin could you kick test for this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-05 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21706 Could someone review ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-04 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21706 @maropu thanks! I got help on the dev email list as well, I've added sql-tests now --- - To unsubscribe, e-mail:

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21706 Adds tests in `sql/core/src/test/resources/sql-tests/inputs/cast.sql` then run `SPARK_GENERATE_GOLDEN_FILES=1 ./build/mvn -Dtest=none -DwildcardSuites=org.apache.spark.sql.SQLQueryTestSuite test`.

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-03 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21706 Just added it to the FunctionRegistry: ```scala scala> spark.sql("DESC function calendarinterval").show(truncate=false)

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-03 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21706 Realized I need to add `calendarinterval` as a function as well to reproduce the behavior of `int`, `date`, `string` etc.. example: ```scala scala> spark.sql("select

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-03 Thread dmateusp
Github user dmateusp commented on the issue: https://github.com/apache/spark/pull/21706 sure! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21706 Can you add tests in `sql/core/src/test/resources/sql-tests/inputs/cast.sql`? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21706 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21706 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21706: [SPARK-24702] Fix Unable to cast to calendar interval in...

2018-07-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21706 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional