Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21806
Merging to master. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21806
LGTM too
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spa
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21806
@hvanhovell Got it. Thanks for your explanation. LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For addi
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21806
@viirya this current change is only useful when you compare canonicalized
plans created on different JVMs. This has come up when we tried to detect
changes in plans over spark versions (plan stab
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21806
The change looks fine. However I'm wondering that have we have chance to
compare hash code between expr ids from different jvms?
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21806
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21806
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93240/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21806
**[Test build #93240 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93240/testReport)**
for PR 21806 at commit
[`68d6f19`](https://github.com/apache/spark/commit/6
Github user gvr commented on the issue:
https://github.com/apache/spark/pull/21806
Updated description, thanks @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21806
otherwise, LGTM pending jenkins
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21806
@gvr can you clean-up the description somewhat? It currently also has part
of the template in it.
---
-
To unsubscribe, e-mai
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21806
**[Test build #93240 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93240/testReport)**
for PR 21806 at commit
[`68d6f19`](https://github.com/apache/spark/commit/68
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21806
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@sp
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21806
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21806
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21806
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
16 matches
Mail list logo
