[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22081 Thanks. Two less JARs on the CP to keep up to date —what more can anyone want? --- - To unsubscribe, e-mail: reviews-uns

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22081 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22081 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22081 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94849/ Test PASSed. ---

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22081 **[Test build #94849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94849/testReport)** for PR 22081 at commit [`d0334c1`](https://github.com/apache/spark/commit/d

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22081 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22081 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2245/

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22081 **[Test build #94849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94849/testReport)** for PR 22081 at commit [`d0334c1`](https://github.com/apache/spark/commit/d0

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-15 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22081 making a test-time option is a reasonable idea -getting the unlimited JCE on the test machines (they don't right now) would remove the need for this --- -

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22081 Makes sense, but then I wonder how the tests work? we need a test dependency on it? --- - To unsubscribe, e-mail: reviews-unsubsc

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22081 I see. I guess I'm trying to figure out whether it's reasonable or not to pull in bouncy castle -- just in the Kinesis module I guess -- on behalf of the user then? That's the default conser

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-14 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22081 No, the SDKs dont pull in bouncy-castle. Checked via mvnrepo * [core sdk](http://mvnrepository.com/artifact/com.amazonaws/aws-java-sdk-core/1.11.271) pulls in jackson & httpclient; hi

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-14 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22081 Hm, I wonder, does the (newer) Kinesis SDK pull in bouncy castle? that's fine if so, that would make sense. If https://github.com/apache/spark/pull/22099 works, then we'll see if this then passes.

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-13 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22081 I've just pushed up my PR which is ~ in sync with this one; I'll close that one now and this can be the one to use. Assume: kinesis uses bouncy castle somewhere. There's some hints i

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-12 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22081 Hm @steveloughran looks like the Kinesis tests fail reliably. That makes me suspicious that jets3t is needed, given that's the AWS dependency here. WDYT? --- ---

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22081 **[Test build #4243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4243/testReport)** for PR 22081 at commit [`a222cb8`](https://github.com/apache/spark/commit/

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22081 **[Test build #4243 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4243/testReport)** for PR 22081 at commit [`a222cb8`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22081 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94632/ Test FAILed. ---

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22081 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22081 **[Test build #94632 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94632/testReport)** for PR 22081 at commit [`a222cb8`](https://github.com/apache/spark/commit/a

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22081 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional comma

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22081 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2090/

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22081 **[Test build #94632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94632/testReport)** for PR 22081 at commit [`a222cb8`](https://github.com/apache/spark/commit/a2

[GitHub] spark issue #22081: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22081 CC @steveloughran --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h..