Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22093
`Should I delete current UT from FileSuit?`
I think current UT in `FileSuite` is unnecessarily, you can leave it and
wait for other reviewer's opinion.
---
---
Github user deshanxiao commented on the issue:
https://github.com/apache/spark/pull/22093
@xuanyuanking I think it carefully later. You are right. The UT just need
to guarantee the KryoSerializer right not all. I will add it in
`KryoSerializerSuite`. Should I delete current UT from Fi
Github user deshanxiao commented on the issue:
https://github.com/apache/spark/pull/22093
@xuanyuanking Thanks for your suggestion. We could indeed test whether
`TaskCommitMessage` can be serialized by `KryoSerializer`. But We could not
explain why the framework must serialize `TaskCo
Github user xuanyuanking commented on the issue:
https://github.com/apache/spark/pull/22093
Why we should create own SparkContext here? Could we just add a UT like
`registration of HighlyCompressedMapStatus` to check `TaskCommitMessage`
working?
---
Github user deshanxiao commented on the issue:
https://github.com/apache/spark/pull/22093
@xuanyuanking I used place the test in it, but KryoSerializerSuite
exteends SharedSparkContext where I could not create my own SparkContext.
---
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22093
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22093
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22093
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
