Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22231
Yeah I noticed that. I think we should leave it, and, if somehow RC1
passes, we'll mark this as fixed for a later release.
---
-
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22231
Note that, RC1 was cut before merging this PR, which means, this patch is
not available in 2.4.0. I hit some problems running the release scripts and
spent quite a lot of time to fix them, so the
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22231
Merged to master/2.4
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96082/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96082 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96082/testReport)**
for PR 22231 at commit
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
@holdenk Can you please do me a big favor and create a separate PR that
makes sure that we are doing at least __flake8 . --count
--select=E901,E999,F821,F822,F823 --show-source --statistics__ on
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96082 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96082/testReport)**
for PR 22231 at commit
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/22231
This looks fine to me as well pending Sean's comment.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96065/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96065 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96065/testReport)**
for PR 22231 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22231
http://pycodestyle.pycqa.org/en/latest/intro.html
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22231
It's weird, `# noqa` should work pep8 (`pycodestyle`) too.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96065 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96065/testReport)**
for PR 22231 at commit
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
Removed the escaped backticks.
@HyukjinKwon Undefined names (F821) is a flake8 error, not a PyCodeStyle
error. That means that PyCodeStyle on its own (this PR) is unable to detect
the
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22231
> OK... # noqa works within the flake8 wrapper around PyFlakes but does not
work when PyFlakes is called outside of flake8. Also added r"comment" as you
suggested.
Is this a bug in
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22231
Oh, that line isn't the error, although the warning says it is! It's really
line 134, which actually has escaped back-ticks. I think you can honestly
remove all of these back-ticks.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96054 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96054/testReport)**
for PR 22231 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96054/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96054 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96054/testReport)**
for PR 22231 at commit
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
OK... Removed backticks and we are once again testing
./dev/run-tests-jenkins.py
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96042/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96042 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96042/testReport)**
for PR 22231 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96042 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96042/testReport)**
for PR 22231 at commit
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
OK... __# noqa__ works within the flake8 wrapper around PyFlakes but does
not work when PyFlakes is called outside of flake8. Also added r"comment" as
you suggested.
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22231
Hm, I don't think the `# noqa` worked. That's the same failure. I thought
it passed locally, hm. Well, I think that line should remove the noqa and
remove the back-ticks. They aren't actually
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22231
shall we fix them here? Looks not many instances
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
@srowen Following the merge of #22400 there are just three W605s at the
bottom of
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96020/console
Should we __# noqa__ those lines
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96020 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96020/testReport)**
for PR 22231 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96020/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #96020 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96020/testReport)**
for PR 22231 at commit
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
Let's wait until #22400 is merged before proceeding with this PR.
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22231
I can really answer my own question, I'm just being lazy. This seems to
work in both Python 2 and 3:
```
>>> re.search('(\d+)\.(\d+)\.(\d+)', "1.2.3").group(1)
'1'
>>>
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/22231
I'm a little slammed this week until Friday, I'll try and cycle back then.
---
-
To unsubscribe, e-mail:
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22231
@srowen Could you please provide some test cases in Python 2 and Python 3
to prove that the changes that you propose will be properly interpreted without
side effects in both?
---
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22231
@holdenk what do you think about the change I proposed above? I didn't know
enough to know whether this was the right fix
---
-
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22231
What do you think @cclauss ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user rekhajoshm commented on the issue:
https://github.com/apache/spark/pull/22231
thanks for the fyi @HyukjinKwon , ack.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22231
Interesting, errors like:
```
./dev/run-tests.py:172:7: W605 invalid escape sequence '\d'
```
on lines like:
```
match = re.search('(\d+)\.(\d+)\.(\d+)',
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #95250 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95250/testReport)**
for PR 22231 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95250/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22231
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22231
**[Test build #95250 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95250/testReport)**
for PR 22231 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22231
I think we can simply skip, for example, `W504 line break after binary
operator` per PEP8:
> In Python code, it is permissible to break before or after a binary
operator, as long as
48 matches
Mail list logo
