Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22355
Thanks for the merging!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22355
thanks, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22355
ping
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user rednaxelafx commented on the issue:
https://github.com/apache/spark/pull/22355
LGTM as well.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22355
cc: @gatorsmile @rednaxelafx Could you check again and merge?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96134/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96134 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96134/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96134 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96134/testReport)**
for PR 22355 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22355
yea, we should do. Before that, I was thinking I would work on fallback for
`SafeProjection` (https://issues.apache.org/jira/browse/SPARK-25374).
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22355
So the next step is, create a `Predicate` factory with fallback?
---
-
To unsubscribe, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22355
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96101/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96101 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96101/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96102/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96102 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96102/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96103/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96103 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96103/testReport)**
for PR 22355 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96103 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96103/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96102 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96102/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #96101 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96101/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95991/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95991 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95991/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95989/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95989 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95989/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95991 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95991/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95989 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95989/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95988/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95988 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95988/testReport)**
for PR 22355 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22355
@sadhen aha, I see. yea, we might need to address it in this pr.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95988 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95988/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user sadhen commented on the issue:
https://github.com/apache/spark/pull/22355
@maropu there are tips to view the codegen:
> spark.sql("explain codegen select 1 + 1").show(false)
You may explain an aggregation, and the NoOp check is obvious.
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22355
Thanks for your review, kirs! I'll update in a day.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22355
Can you check? @gatorsmile @rednaxelafx @cloud-fan @viirya
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95793/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95793 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95793/testReport)**
for PR 22355 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95793 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95793/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/22355
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95781/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95781 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95781/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95781 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95781/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95765/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95765 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95765/testReport)**
for PR 22355 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22355
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22355
**[Test build #95765 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95765/testReport)**
for PR 22355 at commit
73 matches
Mail list logo
