Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
thanks @cloud-fan and @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22364
@mgaido91 well done!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22364
LGTM, merging to master!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
@cloud-fan @dongjoon-hyun @gatorsmile any luck with this? Thanks.
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
I also run on the TPCDS and TPCH benchmark with 10 runs:
Rule | Effective After | Effective Before | Total After | Total Before | %
Eff | % Total
-- | -- | -- | -- | -- | -- | --
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22364
also, cc: @dongjoon-hyun
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
thanks @maropu for your review! @gatorsmile do you have any comments?
---
-
To unsubscribe, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22364
Basically, this change looks good to me. I leave this to other reviewers.
---
-
To unsubscribe, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22364
oh, yea, thanks! I wrongly mixed up `(AttributeSet --
Seq[Attribute]).nonEmpty` with this case.
---
-
To unsubscribe, e-mail:
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
@maropu I have run the following benchmark:
```
test("AttributeSet -- benchmark") {
val attrSetA = AttributeSet((1 to 100).map { i =>
AttributeReference(s"c$i",
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
@maropu anyway I checked and that is the only other places where this
pattern happens. So I am ok including it here. The point is that there the
situation is a bit different, ie. it is not an
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22364
IIUC this pr targets to improve `AttributeSet` operations, so all the
places get the same luck with `ColumnPruning`? If so, I think its ok to fix all
the places in this pr. cc: @gatorsmile
---
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
@maropu yes, that can be done as well, but I think the main focus of this
PR is the `ColumnPruning` rule, so I think it would be great to do that in a
separate PR. What do you think? Thanks.
---
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/22364
Can we replace the syntax(`(ouputSetA -- outputSetB).nonEmpty`) in other
places, too? e.g.,
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
anymore comments @maropu @gatorsmile ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95957/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22364
**[Test build #95957 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95957/testReport)**
for PR 22364 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22364
**[Test build #95957 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95957/testReport)**
for PR 22364 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95944/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22364
**[Test build #95944 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95944/testReport)**
for PR 22364 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22364
**[Test build #95944 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95944/testReport)**
for PR 22364 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95869/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22364
**[Test build #95869 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95869/testReport)**
for PR 22364 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22364
**[Test build #95869 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95869/testReport)**
for PR 22364 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22364
cc @gatorsmile @maropu
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95828/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22364
**[Test build #95828 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95828/testReport)**
for PR 22364 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22364
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22364
**[Test build #95828 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95828/testReport)**
for PR 22364 at commit
41 matches
Mail list logo
