[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-11 Thread mmolimar
Github user mmolimar commented on the issue: https://github.com/apache/spark/pull/22383 No problem. Done ;-) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22383 **[Test build #4368 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4368/testReport)** for PR 22383 at commit [`054c79a`](https://github.com/apache/spark/commit/0

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22383 **[Test build #4368 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4368/testReport)** for PR 22383 at commit [`054c79a`](https://github.com/apache/spark/commit/

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-11 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22383 Yeah, you'll have to add this to the 3.0 excludes section of project/MimaExcludes: `ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.api.java.Optional")` ---

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22383 **[Test build #4376 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4376/testReport)** for PR 22383 at commit [`6eaa3f1`](https://github.com/apache/spark/commit/6

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-13 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22383 **[Test build #4376 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4376/testReport)** for PR 22383 at commit [`6eaa3f1`](https://github.com/apache/spark/commit/

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22383 **[Test build #4379 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4379/testReport)** for PR 22383 at commit [`f188243`](https://github.com/apache/spark/commit/f

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22383 **[Test build #4379 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4379/testReport)** for PR 22383 at commit [`f188243`](https://github.com/apache/spark/commit/

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-16 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22383 Oh, hm: ``` Serialization stack: - object not serializable (class: java.util.Optional, value: Optional[x]) - field (class: scala.Tuple2, name: _2, type: class java.lang.Ob

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-18 Thread mmolimar
Github user mmolimar commented on the issue: https://github.com/apache/spark/pull/22383 I agree @srowen. What do you think about reusing the current implementation we already have, for example, in the guava lib instead of having that class in Spark? --- -

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-18 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22383 Spark's class only reason to exist is so we do *not* use the Guava class, since everyone and their pet want to use a different version of Guava (and Spark shades it for that reason). --- -

[GitHub] spark issue #22383: [SPARK-25362][JavaAPI] Replace Spark Optional class with...

2018-10-18 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22383 Yeah, I think we just can't do this unfortunately. It was worth looking into. --- - To unsubscribe, e-mail: reviews-unsubscr...@