Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/22399
@HyukjinKwon I've opened a new PR under
https://github.com/apache/spark/pull/22637. Would be nice if you can trigger
Travis ð
---
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22399
Let me trigger it in the next PR.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/22399
The tests passed earlier, how would it be possible that it would fail on
master?
---
-
To unsubscribe, e-mail:
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22399
@Fokko, Let's follow the PR format next time BTW, for instance, "How was
this patch tested?"
---
-
To unsubscribe, e-mail:
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22399
It wasn't a merge conflict. I failed to notice this had not actually been
tested. To check locally you'd have to make sure you enable more profiles like
Hive to build some of the code that changed
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/22399
Thanks @srowen for pointing out the errors. Weird that it did not come up
as a merge conflict. Let me open a new PR.
---
-
To
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22399
Sorry @Fokko can you recreate this change in a new PR, after addressing...
```
[error]
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22399
Oh no, I got mixed up and didn't realize this one hadn't actually had a
jenkins run. Sorry about this, that is my mistake. I will follow up.
---
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22399
Jenkins was not triggered in this PR, I'm reverting it. Please re-open it
and make sure jenkins pass, thanks!
---
-
To
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22399
It sounds like the build is broken after merging this PR
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22399
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-compile-maven-hadoop-2.6/8432/
---
-
To
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22399
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-compile-maven-hadoop-2.7/8521/
---
-
To
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22399
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/22399
Rebased onto master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/22399
Cool, makes sense. Thanks for the clarification @srowen
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22399
I think this is fine (though see
https://github.com/apache/spark/pull/22399/files#r218121426 ). As a practical
matter I might wait until we're done with the 2.4 release to start a lot of
changes
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/22399
@srowen Any incentive to move this forward? Or are PR's like these not
appreciated? Let me know.
Most of the changes are cosmetic, but having
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/22399
Addressed comments and rebased onto master, no merge conflicts.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user Fokko commented on the issue:
https://github.com/apache/spark/pull/22399
Thanks for the feedback guys, I was relying too much on Scalastyle :)
---
-
To unsubscribe, e-mail:
Github user TomaszGaweda commented on the issue:
https://github.com/apache/spark/pull/22399
I like this idea :) +1 as it's only refactor, without logic change
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22399
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22399
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22399
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
23 matches
Mail list logo
