Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22420
@wangyum Could you take it over and submit a new PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22420
@hellodengfei Could you change the PR against `master` branch? This change
LGTM. I did a benchmark about `Set` and `Array`:
```scala
def benchmark(func: () => Unit): Long = {
val
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22420
The change LGTM.
Please change the PR against `master` branch as per @dongjoon-hyun 's
suggestion.
It would be nice to have a better PR description :)
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22420
@hellodengfei . Could you make a PR against `master` branch since the
target code is the same with `master` branch? We usually merge into `master`
first, then start to backport to 2.4 and
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/22420
The change seems reasonable to me but could you also improve the
description? I mean, can you provide some evidence about how to reproduce the
issue and see that it is solved? In the JIRA you
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22420
Could you update the PR title. The PR title should be of the form
[SPARK-][COMPONENT] Title.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22420
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22420
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22420
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
