Github user jianjianjiao commented on the issue:
https://github.com/apache/spark/pull/22520
@srowen that makes sense, I will be more patient next time. ^_^.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.a
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22520
Merged to master/2.4/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: revie
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22520
I wouldn't worry unless it's been several days. Depending on urgency and
impact, I leave some time before merging to make sure there aren't more
comments.
---
-
Github user jianjianjiao commented on the issue:
https://github.com/apache/spark/pull/22520
@srowen @vanzin tests passed. What should I do now to make it approved to
merge?
---
-
To unsubscribe, e-mail: reviews-un
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22520
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22520
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96575/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22520
**[Test build #96575 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96575/testReport)**
for PR 22520 at commit
[`d7eed74`](https://github.com/apache/spark/commit/d
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22520
**[Test build #96575 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96575/testReport)**
for PR 22520 at commit
[`d7eed74`](https://github.com/apache/spark/commit/d7
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22520
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.
Github user jianjianjiao commented on the issue:
https://github.com/apache/spark/pull/22520
@srowen Thanks for confirmation. I have sent out new iteration. Could you
please authorize testing on this.
---
-
To uns
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22520
Yeah, I like your suggestion to just have one code path here that works for
all platforms. No need to have used `PosixFilePermissions` in the first place
as there was a utility method for setting per
Github user jianjianjiao commented on the issue:
https://github.com/apache/spark/pull/22520
@srowen thanks for reviewing this PR, and your comments.
1. have fixed the coding style, thanks.
2. These are the only 2 places using PosixFilePermissions to handle file
operations.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22520
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22520
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22520
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
15 matches
Mail list logo
