[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-15 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22560 Sorry for the late reply. Could we hold this PR since we are actively working on the data source API V2? Will revisit it after that. Also cc @gengliangwang @cloud-fan FYI, I just

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-15 Thread fsauer65
Github user fsauer65 commented on the issue: https://github.com/apache/spark/pull/22560 @maropu : This would certainly be another (perhaps better?) way to accomplish the behavior I'm looking for. However, I can't find where JdbcDialect is used on master to abstract

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22560 Just a question about the design: what's the relationship between `JdbcDialect` and tihs provider? In the master, we now abstract JDBC connections by `JdbcDialect`. BTW, you can't reuse

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22560 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22560 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97370/ Test PASSed. ---

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22560 **[Test build #97370 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97370/testReport)** for PR 22560 at commit

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22560 **[Test build #97370 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97370/testReport)** for PR 22560 at commit

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread fsauer65
Github user fsauer65 commented on the issue: https://github.com/apache/spark/pull/22560 tests are failing with ``` Caused by: sbt.ForkMain$ForkError: java.io.NotSerializableException: org.apache.spark.sql.execution.datasources.jdbc.DefaultConnectionFactoryProvider$

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22560 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22560 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97369/ Test FAILed. ---

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22560 **[Test build #97369 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97369/testReport)** for PR 22560 at commit

[GitHub] spark issue #22560: [SPARK-25547][SQL] Pluggable JDBC connection factory

2018-10-14 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22560 **[Test build #97369 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97369/testReport)** for PR 22560 at commit