Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22597
Thank you all!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22597
Merged to master and branch-2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97445/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97445 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97445/testReport)**
for PR 22597 at commit
[`7686179`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97445 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97445/testReport)**
for PR 22597 at commit
[`7686179`](https://github.com/apache/spark/commit/76
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4029/
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22597
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97441/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97441 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97441/testReport)**
for PR 22597 at commit
[`7686179`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97441 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97441/testReport)**
for PR 22597 at commit
[`7686179`](https://github.com/apache/spark/commit/76
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4025/
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22597
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: review
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97436/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97436 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97436/testReport)**
for PR 22597 at commit
[`7686179`](https://github.com/apache/spark/commit/7
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22597
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apa
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97436 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97436/testReport)**
for PR 22597 at commit
[`7686179`](https://github.com/apache/spark/commit/76
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4023/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97366/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97366 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97366/testReport)**
for PR 22597 at commit
[`849c7fa`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97366 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97366/testReport)**
for PR 22597 at commit
[`849c7fa`](https://github.com/apache/spark/commit/84
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3965/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22597
> I haven't looked into, but the parquet record-level filtering is disabled
by default, so if we remove predicates from spark side, the result can be wrong
even if the predicates are pushed ro p
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97329/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97329 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97329/testReport)**
for PR 22597 at commit
[`335a39f`](https://github.com/apache/spark/commit/3
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22597
> In ParquetFilter, the way we test if a predicate pushdown works is by
removing that predicate from Spark SQL physical plan, and only relying on the
reader to do the filter.
I haven't lo
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #97329 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97329/testReport)**
for PR 22597 at commit
[`335a39f`](https://github.com/apache/spark/commit/33
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3937/
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22597
Thanks. I got it. You mean `stripSparkFilter` which is used in both
`OrcQuerySuite.scala` and `ParquetFilterSuite.scala`. Sure!
---
--
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22597
In `ParquetFilter`, the way we test if a predicate pushdown works is by
removing that predicate from Spark SQL physical plan, and only relying on the
reader to do the filter. Thus, if there is a bug
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/22597
Thank you for review, @dbtsai and @gatorsmile .
BTW, what do you mean by removing? The pushed filter doesn't introduce
correctness issue like Parquet. Since it's a performance slowdown
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22597
Yes. Please add a test case.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-ma
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/22597
Is it possible to add tests like parquet to remove the filter in Spark SQL
to ensure that the predicate is pushed down to the reader? Thanks.
---
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96810/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #96810 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96810/testReport)**
for PR 22597 at commit
[`f6c3dca`](https://github.com/apache/spark/commit/f
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3600/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22597
**[Test build #96810 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96810/testReport)**
for PR 22597 at commit
[`f6c3dca`](https://github.com/apache/spark/commit/f6
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22597
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
48 matches
Mail list logo